-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows site root #1626
base: next
Are you sure you want to change the base?
Windows site root #1626
Conversation
1e55db1
to
3155662
Compare
I just tested this on Windows: PR as-is
Ok here means it runs on Windows without visible errors and fixes #1692. PR rebased on next
Rebasing this PR on top of 3155662 also seems to fix #1692 but does not fully expand shortcodes / markdown, producing HTML output like this:
|
Does the last issue happen on the |
Whops. I originally didn't bother testing since without this patch I got the error. But now that you mention it, this does happen on vanilla |
Looking at the output, the shortcode just needs to be a |
Ah, thanks. I wasn't aware that changed. Renaming my shortcodes to |
Has anyone got an idea on how to test that with a unit test? |
@ralfbiedert do you know if the issue still happens on the |
Hm, for whatever reason I can't pull / switch to
|
Test results: Using the latest
The issue reported this time is a console error:
That said, the reverse test (from
Running that reverse test with
|
Ok, I'll try to put this PR in then |
Ok I've fixed the conflicts on this branch, can you give it a try when you have time? I've tried it on mac but it was already working there :/ |
Sure. Note that right now the merged branch (968ba70) doesn't compile anymore (a With that I still get the same error though:
|
Argh :( |
Will this PR possibly be in the next version (0.17.0)? |
It needs to ideally have tests |
I'm not really familiar with Rust at the moment. But, why isn't "get_config_file_path" split into two functions. such as: I think it would be easier to create tests for both of them separately. They seem pretty critical to the rest of Zola's process. |
Can someone on Windows revive this with some tests? |
8b1a413
to
67c2fe0
Compare
#1361
Next attempt 😄
Dont canonicalize paths because windows "\\?" prefix seems to break globbing.
If we have a relative path we turn it into an absolute one using the current_dir.
Maybe those are just workarounds for problems further down. In that case the make_abs_path calls could be removed later.